OCPBUGS-84512: Updates aws external CCM terminationMessagePolicy#80840
Conversation
We're seeing CI fail because we don't set terminationMessagePolicy: FallbackToLogsOnError This fixes how we deploy the external CCM for aws. See https://redhat.atlassian.net/browse/OCPBUGS-84512 for additional context.
|
@theobarberbany: This pull request references Jira Issue OCPBUGS-84512, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
WalkthroughA single line is added to the AWS external CCM configuration shell script, setting ChangesAWS External CCM Container Spec
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 14 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (14 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
[REHEARSALNOTIFIER]
A total of 96 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs. A full list of affected jobs can be found here Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
/pj-rehearse skip Not worth the CI cost. |
|
@theobarberbany: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: elmiko, theobarberbany The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/jira refresh |
|
@theobarberbany: This pull request references Jira Issue OCPBUGS-84512, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
03532bb
into
openshift:main
|
@theobarberbany: Jira Issue OCPBUGS-84512: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-84512 has been moved to the MODIFIED state. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
We're seeing CI fail because we don't set terminationMessagePolicy: FallbackToLogsOnError
This fixes how we deploy the external CCM for aws.
See https://redhat.atlassian.net/browse/OCPBUGS-84512 for additional context.
Summary by CodeRabbit
This PR updates the OpenShift CI infrastructure configuration for the AWS external Cloud Controller Manager (CCM) deployment. Specifically, it adds the
terminationMessagePolicy: FallbackToLogsOnErrorsetting to the container specification in the CCM deployment manifest generated by the step registry script.The change addresses CI failures by ensuring that container termination messages are properly captured in logs when the external CCM pod terminates. The modification is minimal—a single line addition to the deployment configuration script—and does not alter any other manifest content or control flow logic.
File changed:
ci-operator/step-registry/platform-external/ccm/conf/aws/platform-external-ccm-conf-aws-commands.sh(+1 line)This is an infrastructure-focused change that improves the reliability and debuggability of the external CCM deployment on OpenShift clusters using AWS.
Note: The PR references Jira issue OCPBUGS-84512, which the CI bot flagged as lacking a target version assignment (expected "5.0.0"). The validation warning does not block the PR, but the underlying Jira issue may need to be updated with the appropriate version targeting.